p2p: Run checks ealier when processing headers #2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing full node software (dcrd) always sends batches of 2000 headers when requesting headers during Initial Block Download. The check added in this commit ensures the wallet disconnects from any peers that deviate from this behavior. While receiving less than 2000 headers could not cause any consistency or safety issues, it could slow down sync time.
This moves the check for requested headers earlier in the call stack for processing headers messages. This ensures misbehaving peers are disconnected earlier, before spending cpu processing for block hash calculation.
This moves the check that ensures that a reply to a getheaders connects to the existing locators ealier in the call stack for processing a headers response. This ensures the wallet disconnects from misbehaving peers before processing block hashes.
|
how does this work in the 1999/2000 cases when the final set of headers in a sync are sent to the wallet? does it also disconnect the peer? |
|
nvm, it's also checking against the handshake's initial height |
|
Right. The last block (which may have < 2k headers) is accepted, as long as the last header is >= the initial advertised height |
jrick
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running these earlier helps disconnect faster from non-compliant peers.